Add command to set the transfer proxy #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resonant-riches
force-pushed
the
set-transfer-proxy
branch
from
1f737c2 to
e5812e7
Compare
resonant-riches
force-pushed
the
set-transfer-proxy
branch
2 times, most recently
from
6bd3a1c to
97a1fc0
Compare
resonant-riches
commented
Jan 29, 2024
| argv.address != undefined | ||
| ? argv.address | ||
| : argv.useWalletFiles | ||
| ? wallet.ownership.keys.address : |
There was a problem hiding this comment.
The wallet.json has ownership.keys and transfer.keys so I'm not sure which is the correct one to use here.
My assumption is that the goal is for the point to end up being owned by the ownership key, so I should set the transfer proxy to the ownership key and then the ownership key will use the transfer proxy rights to transfer the point to itself. But then I don't see what is the point of the separate "transfer" keys in the wallet.
resonant-riches
force-pushed
the
set-transfer-proxy
branch
from
97a1fc0 to
b3af0fa
Compare
|
hey, thanks for the PR. Sorry for the delay in getting back to you. Let me think about the transfer proxy thing for a moment, but I think it looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.